#307 SettlementForm hardcodes "USDC" as its initial and reset asset d…#399
Conversation
…reset asset default, ignoring availableLiquidity FIXED
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both checklist items are now satisfied. Filled-in PR checklist:
CHANGELOG.mdentry under the next## [x.y.z]section (see the Format note at the top ofCHANGELOG.md), or this PR is docs-only / test-only / internal tooling and doesn't change user-facing behavior.Evidence for the first box:
## [0.9.1]→### Fixedsection toCHANGELOG.md, tagged**UX:**, following the repo's documented format (bold area tag + description of the user-facing effect).package.json"version"from0.9.0→0.9.1to match, since this is a real user-facing bugfix (not docs/test/tooling-only), so the "or" clause doesn't apply — a changelog entry was required and has been added.Evidence for the second box:
src/components/SettlementForm.test.tsxwas updated with 6 new/updated tests covering:"USDC"fallback whenavailableLiquidityis absent,"USDC"fallback when it's empty, default resolving to the first available asset when USDC isn't supported,Resetrestoring that same non-USDC default, and the default recomputing afteravailableLiquidityloads post-mount without clobbering a user's in-progress edit.SettlementForm.tsx.CLOSE #307