#313 apiRequest propagates a raw SyntaxError for a malformed 2xx JSON…#400
Conversation
…rmed 2xx JSON body instead of a descriptive ApiRequestError FIXED
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed
apiRequestso malformed JSON in a successful2xxAPI response no longer leaks a rawSyntaxErrorsuch asUnexpected end of JSON input.Previously,
apiRequestdirectly returnedawait res.json()for successful responses. If the server returned an empty body, HTML, or truncated JSON with a2xxstatus, callers received a raw parser error instead of the app’s friendly API error format.This PR adds defensive parsing for successful JSON responses and throws a descriptive
ApiRequestErrorwith:status: the response status, e.g.200code:INVALID_RESPONSEmessage:The server returned an invalid response.The existing non-2xx
parseErrorbehavior is unchanged, andapiTextRequestremains unaffected.A regression test was added to verify that a
200response whosejson()rejects does not surface a rawSyntaxError.Closes: malformed 2xx JSON body issue.
Checklist
I added a
CHANGELOG.mdentry under the next## [x.y.z]sectionTests added/updated for the change.
CLOSE #313