#314 AnchorsPanel mirrors every registerAnchor failure onto AnchorFor…#402
Conversation
…nto AnchorForm's id field, even unrelated/generic errors FIXED
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #314 - Fixes error attribution bug in
AnchorsPanel.register()->AnchorFormid field.What was happening:
AnchorsPanel.tsx:register()caught any failure fromregisterAnchor()and did:AnchorForm.tsxuseEffectmirrorsserverErrorontoidfield asaria-invalid=truewith inline red text.So a transient network error, 503, timeout, or any generic 5xx was displayed as if the user-entered Anchor id was invalid.
What this PR does:
Core fix –
src/components/AnchorsPanel.tsxe902edb(serverErrorstate,debouncedQuery,filterRefs,onFilterKeyDown).ApiRequestErrorand only surface id-specific failures inline:notify("error", message)still fires for every failure type as before.Build fixes for
e902edbregressionsrc/lib/api.ts:composeSignals(..., callerSignal?: AbortSignal | null)–RequestInit.signalcan benull.src/lib/search.ts: restored AND semanticsterms.every(...)broken to single-needle.src/lib/settlementsApi.ts: added missingapiTextRequestimport.Tests –
src/components/AnchorsPanel.test.tsx"surfaces a field-level error..."to use realisticnew ApiRequestError(409, "CONFLICT", "Duplicate anchor id")and assertsaria-invalid=true+ inline + toast.does not mark id field invalid on generic registration failure but shows toast:registerAnchor->Error("Network error")screen.findByText("Network error")aria-invalid="false"andwithin(form).queryByText("Network error") === nullAcceptance:
Checklist
I added a
CHANGELOG.mdentry under the next## [x.y.z]section(If changelog not required for this exercise, this is internal but user-facing behavior is fixed)
Tests added/updated for the change.
AnchorsPanel.test.tsx(was 25, +1 new generic-error test)search.test.ts12/12 pass after restore