Skip to content

5.5+ Laravel auto-discovery#22

Open
s1rc wants to merge 2 commits into
Andreyco:masterfrom
s1rc:master
Open

5.5+ Laravel auto-discovery#22
s1rc wants to merge 2 commits into
Andreyco:masterfrom
s1rc:master

Conversation

@s1rc

@s1rc s1rc commented Feb 13, 2018

Copy link
Copy Markdown

No description provided.

@Andreyco

Copy link
Copy Markdown
Owner

Thanks for PR. Could you improve formatting? Also, please, could you share some info related to "auto-discovery" feature? Thanks!

@s1rc

s1rc commented Feb 14, 2018

Copy link
Copy Markdown
Author

Fixed the formatting, weird that it didn't show like that on my editor.

With Laravel Auto-Discovery you don't have to register the Service Provider. So Laravel >= 5.5.x you do not need:

'providers' => array(
    // ...
    Andreyco\Instagram\Support\Laravel\ServiceProvider\Instagram::class,
    // ...
),

You still need to register the Facade alias if you plan on using it.

@s1rc

s1rc commented Mar 7, 2018

Copy link
Copy Markdown
Author

Any chance you will approve this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants