-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: 🗂️ Changlog update for v1.2.1 #1838
Conversation
Reviewer's Guide by SourceryThis pull request adds the Changelog entries for the v1.2.1 release, including maintenance, dependency, and testing updates. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anselmoo - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a tool to automatically generate and format the changelog.
- It seems like the changelog entries are overly detailed; focus on user-facing changes.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
||
#### :memo: Changelog | ||
|
||
* docs: :card_index_dividers: Changlog update for v1.2.0 (#1805) @Anselmoo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (typo): Typo: "Changlog" should be "Changelog"
* docs: :card_index_dividers: Changlog update for v1.2.0 (#1805) @Anselmoo | |
* docs: :card_index_dividers: Changelog update for v1.2.0 (#1805) @Anselmoo |
* build: :bookmark: bump version to `v1.2.1` (#1836) @Anselmoo | ||
* fix: :test_tube: remove unnecessary type ignore for AutoPeakDetection instantiation (#1818) @Anselmoo | ||
|
||
#### :octocat: Github Actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (typo): Typo: "Github Actions" should be "GitHub Actions"
#### :octocat: Github Actions | |
#### :octocat: GitHub Actions |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1838 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 45 45
Lines 4535 4535
=========================================
Hits 4535 4535
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
This is an auto-generated pull request to merge release/v1.2.1 with Changelog updates to main.
Summary by Sourcery
Update changelog for v1.2.1 release, including dependency updates, GitHub Actions updates, and pre-commit updates.
Enhancements:
Build:
Documentation:
Tests:
Chores: