Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: ⬆️ bump version to 1.2.2 and update max-version of Python to 3.13 #1844

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Mar 12, 2025

All PR-Submissions:


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:


  • Does your submission pass tests?
  • Have you lint your code locally prior to submission? Fixed:
  • This PR is for a new feature, not a bug fix.

Changes to ⚙️ Core-Features:


  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Summary by Sourcery

Bump version to 1.2.2 and update maximum supported Python version to 3.13.

Build:

  • Update package version to 1.2.2.
  • Update maximum supported Python version to 3.13 in pyproject.toml.

@Anselmoo Anselmoo enabled auto-merge March 12, 2025 21:17
Copy link

semanticdiff-com bot commented Mar 12, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  pyproject.toml Unsupported file format
  spectrafit/__init__.py  0% smaller
  spectrafit/test/test_init.py  0% smaller
  uv.lock Unsupported file format

Copy link
Contributor

sourcery-ai bot commented Mar 12, 2025

Reviewer's Guide by Sourcery

This pull request updates the package version to 1.2.2 and adjusts the maximum supported Python version to 3.13. The version update involves changes in pyproject.toml, spectrafit/__init__.py, and spectrafit/test/test_init.py. The Python version update modifies the requires-python field and classifiers in pyproject.toml.

Updated class diagram for pyproject.toml

classDiagram
    class pyproject.toml {
        -name: str
        -version: str
        -description: str
        -authors: list
        -requires_python: str
        -readme: str
        -license: str
        -maintainers: list
        -keywords: list
        -classifiers: list
    }
    note for pyproject.toml "Version updated from 1.2.1 to 1.2.2.\nMax Python version updated from 3.12 to 3.13."
Loading

File-Level Changes

Change Details Files
Bumped the version of the package from 1.2.1 to 1.2.2.
  • Updated the version field in pyproject.toml.
  • Updated the __version__ variable in spectrafit/__init__.py.
  • Updated the version assertion in spectrafit/test/test_init.py.
pyproject.toml
spectrafit/__init__.py
spectrafit/test/test_init.py
Updated the maximum supported Python version to 3.13.
  • Modified the requires-python field in pyproject.toml to allow up to Python 3.13.
  • Added Python 3.13 to the classifiers in pyproject.toml.
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added testing Improve testing & coverage maintenance Maintenance & Security dependencies Pull requests that update a dependency file python Pull requests that update Python code release Release root labels Mar 12, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anselmoo - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using a tool like bumpversion to automate version updates across multiple files.
  • It's great that you've updated the classifiers in pyproject.toml to include Python 3.13.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1ec5884) to head (d23b9f5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1844   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        45           
  Lines         4535      4535           
=========================================
  Hits          4535      4535           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
spectrafit/__init__.py 100.00% <100.00%> (ø)
spectrafit/test/test_init.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Anselmoo Anselmoo merged commit 19104de into main Mar 12, 2025
60 of 61 checks passed
@Anselmoo Anselmoo deleted the feature/py-3.13 branch March 12, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance Maintenance & Security python Pull requests that update Python code release Release root size/XS testing Improve testing & coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant