Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional mesos_role configuration and tags #27

Merged

Conversation

lhoss
Copy link
Contributor

@lhoss lhoss commented Sep 6, 2016

Required config to use mesos roles in marathon!

ps: We need to change some more marathon configs from the defaults.
For this I propose a generic solution to write simple string $value
to the file `/etc/marathon/conf/$key' (where the user just has to be careful not to overwrite any existing config, by a bad $key setting).

Would this be a good solution?
@ernestas-poskus ?

@ernestas-poskus
Copy link
Member

🆗 but would be more elegant if you would use #28 marathon_additional_configs

@lhoss
Copy link
Contributor Author

lhoss commented Sep 6, 2016

I guess 'my mistake' that I didn't wait to get this PR (27) merged before even opening #28 (that feature I just created today afternoon btw).

But anyway I'ld like the above PR get (stash)merged also because it is more stable in case you want to remove that role option again (in which case the additional configs might still need an extension, for ex. to remove config-files where an empty value was set (instead of writing the file empty.. where I wonder what marathon is doing !) )

@ernestas-poskus
Copy link
Member

I see, ok thank you for contribution merging this and will release under 0.4.0

@ernestas-poskus ernestas-poskus merged commit 10e6c91 into AnsibleShipyard:master Sep 6, 2016
@lhoss lhoss deleted the option_mesos_role branch February 22, 2018 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants