Introduce mutli platform .travis #31
Conversation
ernestas-poskus
force-pushed
the
features/introduce_multi_platform_travis
branch
30 times, most recently
from
77cf9e6 to
1a39a15
Compare
ernestas-poskus
force-pushed
the
features/introduce_multi_platform_travis
branch
3 times, most recently
from
da5a761 to
ab2a28b
Compare
ernestas-poskus
force-pushed
the
features/introduce_multi_platform_travis
branch
from
ab2a28b to
b738166
Compare
| @@ -1,9 +1,9 @@ | |||
| --- | |||
| marathon_playbook_version: "0.3.4" | |||
| marathon_version: "0.8.1" | |||
| marathon_version: "1.3.6" | |||
There was a problem hiding this comment.
👍
using v1.3.6 (was latest 1 week ago) in prod for almost 1 week. Looks good!
| notify: Restart marathon | ||
|
|
||
| - name: Create /etc/sysconfig directory | ||
| file: path=/etc/sysconfig state=directory owner=root group=root mode=0755 |
There was a problem hiding this comment.
That sysconfig folder seems to be outdated (was only used in redhat-style OS, says ->link), then I'm wondering if those env-vars (by default only JAVA_OPTS) are used at all on Ubuntu systemd.
The new recommended way (both redhat/ubuntu) seems to be in /etc/systemd/system/<service-name>.service.d/<something>.conf
Resf:
There was a problem hiding this comment.
You are right I doubt they are used on Ubuntu maybe even on RedHat as well. In my current company I was recently migrating init to systemd and was setuping service.d folders as well so this might be good option to implement it. Systemd supports EnvironmentFile as well but since we use prepacked service it might not be an option here.
| - role: geerlingguy.java | ||
| java_packages: | ||
| - java-1.8.0-openjdk | ||
| when: ansible_os_family == 'RedHat' |
There was a problem hiding this comment.
I'ld expect a solution involving less ansible boilerplate, to simply install a current (open)jdk-8 for different distros (here debian/ubuntu & redhat). or really not?
There was a problem hiding this comment.
My thought was to update README by introducing such dependency to install java 8 because I don't want this playbook to be jack of all trades.
There was a problem hiding this comment.
fully agree 👍
Already >1 year ago I actually proposed the same (removing the java-dep) from another public role (ansible-spark), that we improved+use ourselves
and thought about this beeing a general problem in ansible dependency mgmt, resulting in ansible/ansible#13215 ...
| @@ -1,3 +1,7 @@ | |||
| --- | |||
| - name: Restart marathon | |||
| service: name=marathon state=restarted | |||
|
|
|||
| - name: Reload daemon | |||
| command: systemctl daemon-reload | |||
There was a problem hiding this comment.
Use systemd module: https://docs.ansible.com/ansible/systemd_module.html
Or do we need to support Ansible version <2.2?
There was a problem hiding this comment.
tja, If we could have a statistic about the current ansible-versions used (by users of this role)!
IMO it's a bit early to require 2.2.x, but requiring >2(.1).x OK for me.
To be honest in our company <30% upgraded to 2.2.
There was a problem hiding this comment.
I don't want to require higher Ansible version for this change alone, let's give it some time.
ernestas-poskus
force-pushed
the
features/introduce_multi_platform_travis
branch
7 times, most recently
from
9132559 to
b50e6ff
Compare
Increase level of verbosity when install test role
ernestas-poskus
force-pushed
the
features/introduce_multi_platform_travis
branch
6 times, most recently
from
744cf96 to
ee7df6e
Compare
ernestas-poskus
force-pushed
the
features/introduce_multi_platform_travis
branch
from
ee7df6e to
4cd047b
Compare
|
Made environment variables load under sytemd .d directory validated with tests. |
Replaced init check with
ansible_service_mgrfact.Added systemctl daemon-reload.
Added /etc/sysconfig creation (Ubuntu 16.04) does no have this.
Bumped marathon to 1.3.6.
Introduced tests on 4 platforms of two Linux distributions.