Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BITImageProcessor support for dinov2 model #151

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

narendra9079
Copy link
Contributor

@narendra9079 narendra9079 commented Mar 7, 2025

The change has made as per the preprocessor_config file of the dinov2 model. As compared to the clip Image processor it uses three more function which are do_resize, convert_rgb and do_centercrop. So I added these three function and rest of the flow of the code is same for CLIP Image processor and BIT Image Processor.

@narendra9079 narendra9079 marked this pull request as ready for review March 7, 2025 15:57
@Anush008
Copy link
Owner

Anush008 commented Mar 7, 2025

Thanks @narendra9079. I'll take a look soon.
Could you also run cargo fmt and cargo clippy?

@narendra9079 narendra9079 force-pushed the BITImageProcessor_support branch from c0aa297 to 9059eef Compare March 10, 2025 15:29
Copy link
Owner

@Anush008 Anush008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @narendra9079.

@Anush008 Anush008 linked an issue Mar 11, 2025 that may be closed by this pull request
@Anush008 Anush008 changed the title BITImageProcessor support for dinov2 model feat: BITImageProcessor support for dinov2 model Mar 11, 2025
@Anush008 Anush008 merged commit 9a3bc93 into Anush008:main Mar 11, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BIT Image processor support.
2 participants