fix: resolve CI lint failures and clean up codebase - #144
Merged
usmanimamu17-create merged 3 commits intoJul 31, 2026
Merged
Conversation
- Fix invalid setuptools build-backend in pyproject.toml - Add missing dispatch_webhook_event Celery task - Fix all ruff lint and format issues
Contributor
|
Superseded by PR #145 from Tenny150 |
usmanimamu17-create
requested changes
Jul 29, 2026
usmanimamu17-create
left a comment
usmanimamu17-create
left a comment
Contributor
There was a problem hiding this comment.
@Husten150 resolve conflicts
Resolve merge conflicts with upstream main (103 commits ahead) by keeping main's implementation, then apply ruff lint/format fixes and repair broken imports and type errors so the CI lint, format, and mypy gates pass. Notable fixes: - Restore corrupted app/main.py, app/core/exceptions.py, webhook endpoints, audit_log and webhook_service imports (stray 'main'/'issue/...' merge debris) - Add missing imports (Generator, re, UTC, celery_app, get_or_generate_correlation_id) - Fix OpenTelemetry ASGI response hook (dict response message has no status_code attr) - Add missing foreign_keys to SLAResultORM.disputes relationship
- Add # nosec annotations for legitimate non-crypto random usage and credential-erasure to satisfy bandit (B311, B105) - Pin aquasecurity/trivy-action to v0.28.0 (0.28.0 tag does not exist) - Use 'semgrep scan' instead of 'semgrep ci' (ci lacks --error/--config)
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # ── Trivy scan → SARIF ─────────────────────────────────────────────────── | ||
| - name: Run Trivy vulnerability scanner | ||
| uses: aquasecurity/trivy-action@0.28.0 | ||
| uses: aquasecurity/trivy-action@v0.28.0 |
usmanimamu17-create
approved these changes
Jul 31, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the CI failures from PR #140 by:
Root Causes Fixed
Lint & Type Fixes
Closes #43
Closes #46
Closes #47
Closes #51