The Examples formatting was using string concatenation, I needed more control and I needed to preprocess the docs to allow for changing the output at run time #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich allows the user to render the examples in the method description from a partial, once set, the new example partial will be used.
|
Thanks. Looks promissing. What exactly were the issues for not being able to have a template to achieve the same results as with the string concatenation? |
|
The Issue was that the string concatenation uses markup that I didn't know how it translates exactly to ERB, and it depends on which markup generator was being used. Any ideas on that? Maybe a tag that outputs the markup as the String concat? |
added 2 commits
February 20, 2015 18:14
mark-ellul
changed the title
putting back rails 3.2 dependancy
ofedoren
force-pushed
the
master
branch
2 times, most recently
from
69442b9 to
8215e30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples were being formatted using string concatenation. I needed to have access at the template level.
So I added a new configuration property, render_examples_with_template, which allows the user to render the examples in the method description from a partial, once set, the new example partial will be used, or that partial can be overridden like the others templates.
NOTE: I couldn't get the Example partial to look like the string concatenation, so thats why its configurable.