Replace Maruku with Commonmarker for Markdown

[shqear93]

Removed Maruku with Commonmarker

Maruku is decommissioned and caused me so much troubles

LOOK

Running all tests...
Athar Commons autoload initializer is running

 ___________________________________________________________________________
| Maruku tells you:
+---------------------------------------------------------------------------
| Could not find ref_id = "" for md_link([], nil)
| Available refs are []
+---------------------------------------------------------------------------
!/Users/shqear/.local/share/mise/installs/ruby/3.4.2/lib/ruby/gems/3.4.0/gems/maruku-0.7.3/lib/maruku/output/to_html.rb:656:in 'MaRuKu::Out::HTML#to_html_link'
!/Users/shqear/.local/share/mise/installs/ruby/3.4.2/lib/ruby/gems/3.4.0/gems/maruku-0.7.3/lib/maruku/output/to_html.rb:891:in 'block in MaRuKu::Out::HTML#array_to_html'
!/Users/shqear/.local/share/mise/installs/ruby/3.4.2/lib/ruby/gems/3.4.0/gems/maruku-0.7.3/lib/maruku/output/to_html.rb:879:in 'Array#each'
!/Users/shqear/.local/share/mise/installs/ruby/3.4.2/lib/ruby/gems/3.4.0/gems/maruku-0.7.3/lib/maruku/output/to_html.rb:879:in 'MaRuKu::Out::HTML#array_to_html'
\___________________________________________________________________________

Not creating a link for ref_id = "".


 ___________________________________________________________________________
| Maruku tells you:
+---------------------------------------------------------------------------
| Could not find ref_id = "" for md_link([], nil)
| Available refs are []
+---------------------------------------------------------------------------
!/Users/shqear/.local/share/mise/installs/ruby/3.4.2/lib/ruby/gems/3.4.0/gems/maruku-0.7.3/lib/maruku/output/to_html.rb:656:in 'MaRuKu::Out::HTML#to_html_link'
!/Users/shqear/.local/share/mise/installs/ruby/3.4.2/lib/ruby/gems/3.4.0/gems/maruku-0.7.3/lib/maruku/output/to_html.rb:891:in 'block in MaRuKu::Out::HTML#array_to_html'
!/Users/shqear/.local/share/mise/installs/ruby/3.4.2/lib/ruby/gems/3.4.0/gems/maruku-0.7.3/lib/maruku/output/to_html.rb:879:in 'Array#each'
!/Users/shqear/.local/share/mise/installs/ruby/3.4.2/lib/ruby/gems/3.4.0/gems/maruku-0.7.3/lib/maruku/output/to_html.rb:879:in 'MaRuKu::Out::HTML#array_to_html'
\___________________________________________________________________________

Not creating a link for ref_id = "".


 ___________________________________________________________________________
| Maruku tells you:
+---------------------------------------------------------------------------
| Could not find ref_id = "" for md_link([], nil)
| Available refs are []
+---------------------------------------------------------------------------
!/Users/shqear/.local/share/mise/installs/ruby/3.4.2/lib/ruby/gems/3.4.0/gems/maruku-0.7.3/lib/maruku/output/to_html.rb:656:in 'MaRuKu::Out::HTML#to_html_link'
!/Users/shqear/.local/share/mise/installs/ruby/3.4.2/lib/ruby/gems/3.4.0/gems/maruku-0.7.3/lib/maruku/output/to_html.rb:891:in 'block in MaRuKu::Out::HTML#array_to_html'
!/Users/shqear/.local/share/mise/installs/ruby/3.4.2/lib/ruby/gems/3.4.0/gems/maruku-0.7.3/lib/maruku/output/to_html.rb:879:in 'Array#each'
!/Users/shqear/.local/share/mise/installs/ruby/3.4.2/lib/ruby/gems/3.4.0/gems/maruku-0.7.3/lib/maruku/output/to_html.rb:879:in 'MaRuKu::Out::HTML#array_to_html'
\___________________________________________________________________________

Not creating a link for ref_id = "".


 ___________________________________________________________________________
| Maruku tells you:
+---------------------------------------------------------------------------
| Could not find ref_id = "" for md_link([], nil)
| Available refs are []
+---------------------------------------------------------------------------
!/Users/shqear/.local/share/mise/installs/ruby/3.4.2/lib/ruby/gems/3.4.0/gems/maruku-0.7.3/lib/maruku/output/to_html.rb:656:in 'MaRuKu::Out::HTML#to_html_link'
!/Users/shqear/.local/share/mise/installs/ruby/3.4.2/lib/ruby/gems/3.4.0/gems/maruku-0.7.3/lib/maruku/output/to_html.rb:891:in 'block in MaRuKu::Out::HTML#array_to_html'
!/Users/shqear/.local/share/mise/installs/ruby/3.4.2/lib/ruby/gems/3.4.0/gems/maruku-0.7.3/lib/maruku/output/to_html.rb:879:in 'Array#each'
!/Users/shqear/.local/share/mise/installs/ruby/3.4.2/lib/ruby/gems/3.4.0/gems/maruku-0.7.3/lib/maruku/output/to_html.rb:879:in 'MaRuKu::Out::HTML#array_to_html'
\___________________________________________________________________________

Not creating a link for ref_id = "".

............................................^C
RSpec is shutting down and will print the summary report... Interrupt again to force quit (warning: at_exit hooks will be skipped if you force quit).
.

Finished in 1.52 seconds (files took 2.25 seconds to load)
45 examples, 0 failures

[ekohl]

Last update in 2017, that's old.

I'm looking at commonmarker and I see it's pulling in a rust crate. That does significantky increase toolchain size. Not sure if we should mandate that. Also requires Ruby 3.2 and in our current version we still carry older support.

I kicked off CI to see how that behaves

[shqear93]

@ekohl what do you think about redcarpet? https://github.com/vmg/redcarpet

[mathieujobin]

I think pulling rust is acceptable. its should only be pulled once per ruby version, and more and more gems will be using it.

[mathieujobin]

Can you update the changelog with your entry? Respecting current style?

[ekohl]

Pulling in rust may not work for Foreman packaging. Please let's make sure that works before merging this.

Cc @evgeni

[evgeni]

I have no idea about Rust, but I know @Odilhao builds Rust things for Python already

[Odilhao]

I have no idea about Rust, but I know @Odilhao builds Rust things for Python already

Rust bindings requires me to always vendor the crates every update, it's a really fun process.