Skip to content

Decrease the minimum allowed timeout #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martintmk merged 1 commit into from
Jan 10, 2024
Merged

Decrease the minimum allowed timeout #1888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Polly.Core/Timeout/TimeoutStrategyOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public class TimeoutStrategyOptions : ResilienceStrategyOptions
/// <value>
/// This value must be greater than 1 second and less than 24 hours. The default value is 30 seconds.
/// </value>
[Range(typeof(TimeSpan), "00:00:01", "1.00:00:00")]
[Range(typeof(TimeSpan), "00:00:00.010", "1.00:00:00")]
[UnconditionalSuppressMessage("Trimming", "IL2026", Justification = "Addressed with DynamicDependency on ValidationHelper.Validate method")]
public TimeSpan Timeout { get; set; } = TimeSpan.FromSeconds(30);

Expand Down
3 changes: 3 additions & 0 deletions test/Polly.Core.Tests/Timeout/TimeoutTestUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,15 @@ public static class TimeoutTestUtils
TimeSpan.Zero,
TimeSpan.FromSeconds(-1),
TimeSpan.FromHours(25),
TimeSpan.FromMilliseconds(9),
};

public static readonly TheoryData<TimeSpan> ValidTimeouts = new()
{
TimeSpan.FromSeconds(1),
TimeSpan.FromHours(1),
TimeSpan.FromMilliseconds(10),

};
#pragma warning restore IDE0028
}