Skip to content

fix(android) Unused Plugin registration using Android embedding v1 #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

taylanyildiz
Copy link

Fix: Remove unused Plugin registration using Android embedding v1

Description

This PR comments out the registerWith method, which was using the deprecated Android embedding v1 API. The method was causing a compilation error due to the removal of PluginRegistry.Registrar in Flutter.

Issue
• The build was failing with the following error:

error: cannot find symbol
import io.flutter.plugin.common.PluginRegistry.Registrar;
                                              ^
•	PluginRegistry.Registrar is no longer available in Flutter’s modern embedding API.

Solution
• The unused registerWith method has been commented out to prevent build failures.
• This aligns the plugin with Flutter’s latest Android embedding v2 requirements.

Testing
• Verified that the plugin builds successfully without errors.

Let me know if you need any modifications! 🚀

@mcmarkj
Copy link

mcmarkj commented Apr 29, 2025

Hi 👋

Thanks so much for this PR - this is what we need to update our flutter version.

@sgong-pdftron / @dluco / @brandenfung2 - just bringing this to your attention if it wasn't already as it would be awesome to get this released.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants