Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple crest height updates #52

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

rqthomas
Copy link
Contributor

This PR addresses the following

  • overland flow through a weir was calculated as m3/s instead of the m3/day that is required by the do_single_outflow function. The PR fixes this by adding a new internal variable called day_fraction that is the proportion of a day that cover by the current day of the simulation. A mid-night to mid-night simulation has a day_fraction = 1.0. day_fraction can be multiplied by the number of seconds in a day to get the number of seconds in the current day of the simulation.
  • seepage was also m3/s so needed to be coverted to m3/day
  • there was a check as initalization that compare the height of the top layer to the crest elevation. The checked needed to compare to the max elevation since it is possible to have water higher than a weir elevation (which is what the crest elevation represents).

@rqthomas
Copy link
Contributor Author

Addresses #51

@rqthomas
Copy link
Contributor Author

I fixed another issue where multiple values for the same time-step would occur in the netcdf output when starting on non 00:00 hours (so the last day was not a full day).

@rqthomas
Copy link
Contributor Author

This PR now includes an additional write_output step that occurs before the daily loop. This allows the initial conditions to be reflected in the model output.

@rqthomas
Copy link
Contributor Author

rqthomas commented Nov 7, 2024

@casper-boon @matthipsey Don't forget this PR as you move to version 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant