-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple crest height updates #52
base: master
Are you sure you want to change the base?
Conversation
Addresses #51 |
I fixed another issue where multiple values for the same time-step would occur in the netcdf output when starting on non 00:00 hours (so the last day was not a full day). |
This PR now includes an additional write_output step that occurs before the daily loop. This allows the initial conditions to be reflected in the model output. |
@casper-boon @matthipsey Don't forget this PR as you move to version 4. |
This PR addresses the following
day_fraction
that is the proportion of a day that cover by the current day of the simulation. A mid-night to mid-night simulation has a day_fraction = 1.0. day_fraction can be multiplied by the number of seconds in a day to get the number of seconds in the current day of the simulation.