Engine: NPEs accessing rid when it is null

[giastfader]

ArcadeDB Version: 21.9.1-SNAPSHOT

JDK Version: N/A

OS: N/A

I found at least two points where there is an explicit use of the rid variable when it is for sure null, because there is an explicit test on the null condition.

arcadedb/engine/src/main/java/com/arcadedb/query/sql/parser/Rid.java

Line 167 in bb85560

public PInteger getBucket() {

    public PInteger getBucket() {
        if (expression != null) {
            RID rid = toRecordId((Result) null, new BasicCommandContext());
            if (rid == null) {
                PInteger result = new PInteger(-1);
                result.setValue(rid.getBucketId());
                return result;
            }
        }
        return bucket;
    }

    public PInteger getPosition() {
        if (expression != null) {
            RID rid = toRecordId((Result) null, new BasicCommandContext());
            if (rid == null) {
                PInteger result = new PInteger(-1);
                result.setValue(rid.getPosition());
                return result;
            }
        }
        return position;
    }

[lvca]

I believe we get that code from OrientDB when we ported the SQL layer.

[antarcticgiraffe]

Hi @lvca @giastfader

I checked OrientDB code and it's exactly the same.
I agree with you that this logic makes no sense at all. Probably the null check is just inverted, ie. if the expression exists, try to use it to calculate the RID and in case (rid != null) use it to return the bucket or the position; otherwise just use the raw bucket/position value.

I'm fixing the code in this sense.

We should also report the problem to OrientDB project, as it could be of interest.

Regards

AG

[antarcticgiraffe]

Fixed with 11b6800