Core: Move GER EntranceLookup onto ERPlacementState. Improve usefulness of on_connect #4904
+122
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This makes a variety of general enhancements to the data available to the on_connect callback in GER. The motivator for this is to allow making additional entrance connections in this callback, which was always intended but implemented incredibly poorly
er_state.connect
without having to manage the EntranceLookup.find_target
method on EntranceLookup, allowing callers to search for unplaced entrances to be able to make their own placements (functional equivalent ofget_entrance
for the uncached ER targets)True
, and allow an additional state sweep afterwards if neededHow was this tested?
Added new unit tests for the new method and verified existing behavior has not regressed.