Skip to content

CommonClient: Move command marker to last_autofillable_command #4907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Jouramie
Copy link
Contributor

What is this fixing or adding?

This changes the command marker ! from being hardcoded in get_input_text_from_response, to being explicit in last_autofillable_command. This allows / commands to use last_autofillable_command to be autofilled when user presses the "Didn't find something that closely matches 'something wrong', did you mean 'the correct name'? (66% sure)" message.

I need this to fix an issue with the Stardew client tracker. Currently, when pressing the autofill questions, the !hint command gets filled instead of the correct /explain command. Setting the last command to explain autofills !explain, with the wrong command marker.

Without this change, I would need to hook into the ConnectBarTextInput in intercept when the command is autofilled to change the marker. Every other client would also need to do that if they want the same behavior.

How was this tested?

I made typo with !hint, !hint_location, !getitem to make sure they still work. I also tested with the /explain commands from the Stardew client. See this commit agilbert1412@d2fdda4

If this makes graphical changes, please attach screenshots.

Current Stardew Client behavior

Screen.Recording.2025-04-20.at.12.34.12.PM.mov

With this change + setting `last_autofillable_command` correctly in the client

Screen.Recording.2025-04-20.at.12.28.06.PM.mov

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 20, 2025
Copy link
Collaborator

@agilbert1412 agilbert1412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes do what they claim to do, but this is core, and I'm about 74 years too early to claim that I have any clue what the potential repercussions could be, so take my approval as like, 1/14th of an approval.

@ScipioWright ScipioWright added the is: enhancement Issues requesting new features or pull requests implementing new features. label Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants