Core: move gui_enabled to Utils
#4925
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
alwaysintreble
added
the
is: refactor/cleanup
qwint
approved these changes
Apr 26, 2025
There was a problem hiding this comment.
code is a simple move, pure code review
I'd personally like for nogui to be handled in the launcher (accepted as an arg, removed from passthrough args, potentially even offer a nogui version of launcher itself) before it would need to be moved out of cc, but it's much easier to just make the move first
alwaysintreble
added
waiting-on: core-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Just moves the variable definition so it can be more easily used by non-CommonClient derived, but GUI-optional apps.
How was this tested?
py CommonClient.py --nogui