Kivy: swap from the tab carousel to navigation bar #4930
+70
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
affects: core
Silvris
reviewed
Apr 26, 2025
Comment on lines
+930
to
+933
| if -1 < index <= len(self.tabs.children): | ||
| index = len(self.tabs.children) - index | ||
| self.tabs.add_widget(new_tab, index=index) | ||
| self.screens.add_widget(new_screen, index=index) |
There was a problem hiding this comment.
May need to check this behavior, the reason this was added is because the add_widget indexing is inverted between the tabs container and the carousel
Comment on lines
-771
to
-776
| def remove_tab(self, tab, content=None): | ||
| if content is None: | ||
| content = tab.content | ||
| self.ids.container.remove_widget(tab) | ||
| self.carousel.remove_widget(content) | ||
| self.on_size(self, self.size) |
There was a problem hiding this comment.
There are clients relying on this function (UT iirc), so removing it may not be the best choice. Especially if the tab behavior is being split between self.tabs and self.screens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Navigation bar is a bit less buggy, but it doesn't come with a built-in underline, so that had to be made custom. The only noticeable change here from the user perspective is that the underline is more responsive, while this offsets a bunch of boilerplate off to the kv to make it easier to maintain.
How was this tested?
Tried out various clients that have various amounts of tabs and checked that they still behaved as expected. Still currently has an issue where the underline won't get moved to the proper position after everything has finished getting set up and not sure how to fix it.