Tests: test a single-player generation through generate_output #4931
Conversation
github-actions
bot
added
the
waiting-on: peer-review
| game: ClassVar[str] | ||
|
|
||
| def test_single_player_game_can_generate_output(self) -> None: | ||
| if self.game in ("Archipelago", "Sudoku", "Final Fantasy"): |
There was a problem hiding this comment.
I'm not sure what the proper way for us to check Final Fantasy or sudoku is, but generic can at least be skipped with hidden which it should probably be done that way?
There was a problem hiding this comment.
Honestly the best solution for Sudoku is probably marking it hidden and figuring out a way for it to keep its docs on Webhost (or a new field that does exactly that).
Final Fantasy we just have to manually exclude, but since Final Fantasy's output is handled by FFR upstream, we don't have to worry about it.
There was a problem hiding this comment.
FWIW though Archipelago doesn't actually fail the test. It just doesn't make sense to test it at all.
There was a problem hiding this comment.
sudoku signals it can't generate to the webhost with web.options_page = False so ???
There was a problem hiding this comment.
Nothing else in core uses that as a signal though. You still get Sudoku yamls produced by the launcher.
| output = tempfile.TemporaryDirectory() | ||
| with output as temp_dir: | ||
| call_stage(self.multiworld, "generate_output", temp_dir) | ||
| call_single(self.multiworld, "generate_output", 1, temp_dir) |
There was a problem hiding this comment.
does it make sense for us to assert that the world actually put something in the temp directory?
There was a problem hiding this comment.
We can, but then we'd also have to filter out all worlds where world_type.generate_output == World.generate_output.
ScipioWright
added
the
is: enhancement
What is this fixing or adding?
Adds a test that generates a single player multiworld with a given game, then runs
stage_generate_outputandgenerate_outputwith the multiworld.How was this tested?
It's a unit test, ran unit tests. On opening this PR, the only failure should be The Wind Waker (which has been reported).
If this makes graphical changes, please attach screenshots.