WebHostLib: Properly format IDs in API responses

[qwint]

What is this fixing or adding?

update the id formatter to use staticmethods to not fake the unused self arg, and then use the formatter for the user session endpoints

found testing #4887
the user session responses have unusable ids that cause the id parser on webhost to error out with a ValueError: bytes is not a 16-char string
this also refactors the formatter class to use the staticmethod decorator like it's already being used

How was this tested?

import requests

s = requests.Session()

# grab the session cookie for my localhost which has existing data
s.get("http://localhost/session/a66f6a05-5c23-4473-8cc0-f9b2c70c27bb")
api_base = "http://localhost/api"

get_rooms_response = s.get(f"{api_base}/get_rooms")
assert get_rooms_response.status_code == 200, "get_rooms failed"
rooms = get_rooms_response.json()
first_room = rooms[1]["room_id"]
room_status_response = s.get(f"{api_base}/room_status/{first_room}")
assert room_status_response.status_code == 200, "room_status failed"
room_data = room_status_response.json()
print(room_data)

and manually pinging the different apis and using returned ids in more api calls in browser

If this makes graphical changes, please attach screenshots.

[alwaysintreble]

I'm not really sure why they were instance methods in the first place, but this all looks correct. I'm not really sure why our api endpoints were all returning the encoded versions instead of the url safe decoded since those are unusable without the client requesting the information doing the same decoding the webhost already has to do in other places, so definitely support returning all of them as decoded.

[Berserker66]

This breaks pattern with the parent class:

[Berserker66]

I'm not really sure why they were instance methods in the first place,[...]

It's rather simple, really. I looked at the implementation of other Convertors.

[qwint]

I can pull those functions out to standalone helpers if you really want, but i really hope their code isn't depending on Class.to_python(None, value)...

[alwaysintreble]

If we really want to follow that pattern then we're better off instantiating it

[qwint]

updated with new helpers to be used by other calls and reverting Converter class to BaseConverter style