wayback.py: Fix undefined names discovered by ruff #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
% `ruff check --output-format=github --select=E9,F63,F7,F82` ``` Error: server/api/archive.py:342:25: F821 Undefined name `url` Error: server/api/books.py:263:9: F821 Undefined name `self` Error: server/api/books.py:264:23: F821 Undefined name `self` Error: server/views/apis/v1/books.py:154:61: F821 Undefined name `access` Error: server/views/apis/v1/books.py:154:76: F821 Undefined name `secret` Error: server/views/apis/v1/items.py:38:21: F821 Undefined name `iid` Error: server/views/apis/v1/wayback.py:33:13: F821 Undefined name `requests` Error: Process completed with exit code 1. ``` https://docs.astral.sh/ruff
Fixes undefined names discovered by ruff.
% `ruff rule F821`
# undefined-name (F821)
Derived from the **Pyflakes** linter.
## What it does
Checks for uses of undefined names.
## Why is this bad?
An undefined name is likely to raise `NameError` at runtime.
## Example
```python
def double():
return n * 2 # raises `NameError` if `n` is undefined when `double` is called
```
Use instead:
```python
def double(n):
return n * 2
```
## Options
- [`target-version`]: Can be used to configure which symbols Ruff will understand
as being available in the `builtins` namespace.
## References
- [Python documentation: Naming and binding](https://docs.python.org/3/reference/executionmodel.html#naming-and-binding)
cclauss
changed the title
cclauss
commented
Jun 13, 2025
|
|
||
| @rest_api | ||
| def post(self): | ||
| def post(self, iid): |
There was a problem hiding this comment.
Changes the API calling convention!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please carefully review the change to
server/views/apis/v1/items.py, as a change is needed, but the proposed change modifies the API calling convention.%
ruff check --output-format=github --select=E9,F63,F7,F82https://docs.astral.sh/ruff
%
ruff rule F821undefined-name (F821)
Derived from the Pyflakes linter.
What it does
Checks for uses of undefined names.
Why is this bad?
An undefined name is likely to raise
NameErrorat runtime.Example
Use instead:
Options
target-version]: Can be used to configure which symbols Ruff will understandas being available in the
builtinsnamespace.References