This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Closed
Conversation
Author
|
Actually did some major refactoring since, going to close this without merging and open two new PRs:
Closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2
I'll try to keep PRs much smaller than this in the future so they're easier to review.
Includes:
active:falsetruecomes along we can review the wording then, these are effectively in draftLearned to make custom fields so we get something like this in the HTML:
The custom hook in
doorstop_hooks.pymakes the customrationalefield required.Still working out how to get the default values to work for custom attributes, not appearing to work so far...