Open
Conversation
lindsgil
changed the title
Base automatically changed from
ryley/pro-1239-publish-a-few-simple-augmentation-hooks-for-launch
to
main
April 4, 2025 16:54
ryley-o
approved these changes
Apr 7, 2025
| * child contracts implement the required IWeb3Call functions. | ||
| */ | ||
| abstract contract InjectEthPrice is AbstractPMPAugmentHook { | ||
| AggregatorV3Interface internal dataFeed; |
Contributor
There was a problem hiding this comment.
nit: I think could be immutable + public
Comment on lines
+41
to
+43
| dataFeed = AggregatorV3Interface( | ||
| 0x5f4eC3Df9cbd43714FE2740f5E3616155c5b8419 | ||
| ); |
Contributor
There was a problem hiding this comment.
nit: prefer to make this a constructor arg to have source code be chain-agnostic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Publish a few basic PMP augmentation contracts as examples.
These examples can provide a starting point for future augmentation hook contracts.