Update dependency registry with three new script fields#1814
Open
Update dependency registry with three new script fields#1814
Conversation
…cies-in-dependency-registry
…cies-in-dependency-registry
…cies-in-dependency-registry
…cies-in-dependency-registry
yoshiwarab
approved these changes
May 31, 2025
yoshiwarab
reviewed
May 31, 2025
| CanvasTag canvasTag; | ||
| // whether the dependency should be loaded as a module | ||
| bool loadAsModule; | ||
| // project script special type for the dependency |
Contributor
There was a problem hiding this comment.
Nit: I feel like this comment could be a little clearer that it's the type attribute on the project script tag because type just feels pretty generic. Might also make sense to call it projectScriptTagSpecialType for clarity but don't feel too strongly about that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Update dependency registry with three new script fields to fully prescribe generator behavior.
The three new fields enable the dependency registry to sufficiently prescribe how each project should be rendered in the generator. This will lead to the removal of any dependency-name-based logic from the on-chain generator in a subsequent PR.