Skip to content

Commit

Permalink
[TEAMMATES#12692] Update Angular to 16 and Node to 18 (TEAMMATES#12694)
Browse files Browse the repository at this point in the history
* Fix duplicate comment button bug in question submission

* Update front-end dependencies, Angular to 16

* Update Angular app configurations

* Update implementation code

* Update test settings + snapshot

* Fix new eslint violations

* Update stylelint, add prettier to lint for aesthetic-only issues

* Make Node.js 18 the minimum requirement

* Add BaseAxeTestCase with ability to selectively ignore issues

* Make all Axe tests inherit BaseAxeTestCase
  • Loading branch information
wkurniawan07 authored Jan 26, 2024
1 parent b60f8db commit 09024c5
Show file tree
Hide file tree
Showing 576 changed files with 12,151 additions and 29,344 deletions.
16 changes: 0 additions & 16 deletions .browserslistrc

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/axe.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- name: Set up JDK 11
uses: actions/setup-java@v3
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/component.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
fetch-depth: '0'
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- name: Set up JDK 11
uses: actions/setup-java@v3
with:
Expand Down Expand Up @@ -71,7 +71,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- name: Set up JDK 11
uses: actions/setup-java@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dev-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- uses: actions/setup-java@v3
with:
java-version: '11'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-cross.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- name: Set up JDK 11
uses: actions/setup-java@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- name: Set up JDK 11
uses: actions/setup-java@v3
with:
Expand Down
1 change: 0 additions & 1 deletion angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
"polyfills": "src/web/polyfills.ts",
"tsConfig": "tsconfig.app.json",
"allowedCommonJsDependencies": [
"core-js",
"moment-timezone"
],
"assets": [
Expand Down
2 changes: 1 addition & 1 deletion docs/axe-testing.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ Any individual accessibility test | `./gradlew axeTests --tests TestClassName` |

## Creating Accessibility Tests

Accessibility test classes in TEAMMATES are similar to [E2E test classes](e2e-testing.md#creating-e2e-tests) in that they inherit from `BaseE2ETestCase` and make use of page objects. The difference is that testing is conducted by running `AxeUtil.AXE_BUILDER.analyze()` on the page object's underlying browser driver.
Accessibility test classes in TEAMMATES are similar to [E2E test classes](e2e-testing.md#creating-e2e-tests) in that they inherit from `BaseAxeTestCase` (which inherits `BaseE2ETestCase`) and make use of page objects. The difference is that testing is conducted by running `AxeBuilder#analyze` on the page object's underlying browser driver.
6 changes: 3 additions & 3 deletions docs/setting-up.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ These tools are necessary regardless of whether you are developing front-end or

If you want to develop front-end, you need to install the following:

1. Install Node.js (minimum version 16).
1. (Optional but highly recommended) Install Angular CLI version 14 globally.
1. Install Node.js (minimum version 18).
1. (Optional but highly recommended) Install Angular CLI version 16 globally.
```sh
npm install -g @angular/cli@14
npm install -g @angular/cli@16
```
**Verification:** Run `ng --help` and you should see a list of available Angular CLI commands.

Expand Down
1 change: 1 addition & 0 deletions jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ module.exports = {
],
moduleNameMapper: {
d3: '<rootDir>/node_modules/d3/dist/d3.min.js',
'lodash-es': 'lodash'
},
globalSetup: 'jest-preset-angular/global-setup',
};
Loading

0 comments on commit 09024c5

Please sign in to comment.