Gradually remove base64 data from a dApp developer object #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 66ef159): https://astar-token-api--pr166-fix-remove-base64-da-lmcromb7.web.app (expires Thu, 27 Mar 2025 09:55:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f99fa4f4f8f3bb450e6e842f7e1c7783d6d896a3 |
gtg7784
approved these changes
Mar 21, 2025
impelcrypto
approved these changes
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long time ago I added a dApp developer images as base64 encoded data to JSON object. This hurts API (and the portal of course) performance so this PR contains changes to gradually upload base64 data as image to Firebase and to assign the uploaded image link to a dApp developer.
When I say gradually this means that all dApps won't be updated at once (I want to avoid the mayor catastrophe in case of bug). The above mentioned change will happen when