Engine update to Node v20 #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 13c8a67): https://astar-token-api--pr169-feat-node20-i3j8axsn.web.app (expires Thu, 22 May 2025 08:43:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f99fa4f4f8f3bb450e6e842f7e1c7783d6d896a3 |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project to use Node v20 and ensures the API documentation is aligned with the new engine version. It includes:
- An update to the Node engine version in package.json.
- Adjustments in both the controller's swagger annotations and swagger.json to refine the documentation for the network parameter.
- Updates to GitHub Actions workflows to specify Node v20.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/controllers/TokenStatsController.ts | Adjusted swagger parameter description formatting. |
| public/swagger.json | Enhanced the network parameter details with a description and enum. |
| package.json | Updated Node engine version from 18 to 20. |
| .github/workflows/pr_action.yml | Updated workflow node-version references from 18.x to 20.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems we need to switch to v20. Token API can't be deployed to Firebase anymore.