Open
Conversation
Previous code extracted values from JAX arrays and convert to Python ints at runtime. This will fail when the function is JIT-compiled because JAX arrays become tracers during compilation, and int() on a tracer raises an error. The vocab_sizes parameter must be provided to __init__ for this method to work with JIT.
…reating factored process configurations. Added parameterized tests for valid and invalid configurations, improving test coverage and maintainability.
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Introduce a unified FactoredGenerativeProcess with pluggable conditional structures and builders, plus utilities and extensive tests/configs.
FactoredGenerativeProcesssupporting composite vocabularies and per-factor state transitions.simplexity/generative_processes/structures):IndependentStructure,SequentialConditional,FullyConditional,ConditionalTransitions.builder.py):build_factored_processandbuild_factored_process_from_specfactories.build_matrices_from_spec,build_chain_from_spec,build_symmetric_from_spec,build_transition_coupled_from_spec.HiddenMarkovModelwithout device arg in nonergodic builder.utils/factoring_utils.py):compute_obs_dist_for_variant,transition_with_obs, andTokenEncoderfor factor encoding/updates.validate_transition_matriceswith eigenvalue check and normalization warning.independent,chain,symmetric, andtransition_coupledstructures.jax.Arraytypes.Written by Cursor Bugbot for commit eac6194. This will update automatically on new commits. Configure here.