Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chart image to readme #72

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Add chart image to readme #72

merged 2 commits into from
Apr 9, 2024

Conversation

harlantwood
Copy link
Contributor

@harlantwood harlantwood commented Mar 12, 2024

Same idea as outlined in #70 -- to immediately give the user the visual idea of what is possible.

You can see the rendered version of the README with image here: https://github.com/harlantwood/AstroChart/tree/patch-1?tab=readme-ov-file#astrochart

@afucher
Copy link
Contributor

afucher commented Mar 18, 2024

Hey @harlantwood ,
From where this image is? https://github.com/AstroDraw/AstroChart/assets/38769/0adc6822-7145-4e33-9e0b-53065e96d61a
Sorry, if I'm missing something, but I did not found where this image is.

@harlantwood
Copy link
Contributor Author

Hey @harlantwood ,
From where this image is? https://github.com/AstroDraw/AstroChart/assets/38769/0adc6822-7145-4e33-9e0b-53065e96d61a
Sorry, if I'm missing something, but I did not found where this image is.

I made the PR via GitHub UI, uploaded the image in the UI, and GitHub gave it that URL… so, GitHub magic. ✨

@afucher
Copy link
Contributor

afucher commented Mar 21, 2024

I made the PR via GitHub UI, uploaded the image in the UI, and GitHub gave it that URL… so, GitHub magic. ✨

Hmmm... so I fhink that is better to upload the image to the repo in a folder and reference it in the README.

Copy link
Contributor

@afucher afucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the image to the repo, so we do not depend on Github magic ✨

@harlantwood
Copy link
Contributor Author

Added the image in a separate PR: #75.

We should merge that one first.

After that, the branch behind this PR will show the image correctly in its readme when clicking this link:

https://github.com/harlantwood/AstroChart/tree/patch-1#example

What you should see there will be something like:

Screen Shot 2024-03-30 at 10 54 52 PM

@afucher afucher merged commit f1fdbbe into AstroDraw:main Apr 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants