Add HTTPS proxy support and fix broken test. #1795
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What happened to this PR? We tried using AHC (both v1 and v2) with HTTPS proxy (specifically squid with https_port enabled and self-signed certificate) and it's completely broken, both versions try to send plain request over TLS + v2 only uses securedPort when request protocol is https. |
|
Can you rebase this with the latest changes so I can pull this in? |
|
Are there any plans to get this PR merged in @hyperxpro? Where do you need help? |
+1 to this. How can we help to get this merged? |
|
@NicoZelaya @mredolatti - I need this PR to be rebased with latest changes; then I will review and pull in. :) |
|
Finished in #2109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.