fix(svelte): bump tree-sitter-htmlx-svelte to 0.1.16 to stop SIGSEGV (#471) - #472
Merged
Conversation
…471) Building a graph over .svelte components deterministically crashed with SIGSEGV (exit 139) on Linux/glibc: an invalid free in the tree-sitter-htmlx-svelte 0.1.8 grammar's scanner, hit during parallel graph construction. macOS's allocator tolerated the bad free, so it only surfaced on Linux. 0.1.16 carries the scanner cleanups; the existing "0.1.7" constraint already permitted it, so this is a lock-only update. Adds a parallel-Svelte-graph regression test that builds a graph over multiple .svelte components (the crashing path). Thanks @XF-FW for the exhaustive isolation and the verified fix.
![inspect-review[bot]](https://avatars.githubusercontent.com/in/3177512?s=60&v=4){kind=small}
There was a problem hiding this comment.
inspect review
Triage: 1 entities analyzed | 0 critical, 0 high, 0 medium, 1 low
Verdict: standard_review
Findings (0)
Reviewed by inspect | Entity-level triage found 0 high-risk changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #471.
Problem
sem graph/context/orientover.sveltecomponents deterministically crashed with SIGSEGV (exit 139) on Linux/glibc, an invalid free in thetree-sitter-htmlx-svelte0.1.8 grammar's scanner, hit during parallel graph construction. macOS's allocator tolerated the bad free, so it only surfaced on Linux, which is why it never showed locally or in the Svelte unit test.Fix
Bump the grammar to 0.1.16 (scanner cleanups / crash fixes after 0.1.8). The existing
sem-coreconstraint"0.1.7"already permits it, so this is a lock-only dependency update, no source constraint change.Verification
handleLogoClick,count, script/fragment entities all extracted):sem context handleLogoClick --file spa/src/routes/+page.svelte --no-cache --file-exts .sveltesem graph spa/src --no-cache --file-exts .svelte --format jsongraph_svelte_parallel_no_crash_issue_471: builds a graph over 12.sveltecomponents (the parallel path that crashed). Fails only on Linux/glibc CI with 0.1.8; passes with 0.1.16.Credit to @XF-FW for the exhaustive isolation (GDB backtrace, per-extension bisection) and the already-verified fix. Follow-up: cut a patch release once merged.