Fix usage of sentry cli in CI #10977
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
schottra
approved these changes
Mar 7, 2025
| - run: | ||
| name: upload-sourcemaps | ||
| command: | | ||
| cd packages/web | ||
| ../../node_modules/.bin/sentry-cli --auth-token ${SENTRY_AUTH_TOKEN} releases --org audius --project audius-client files ${CIRCLE_SHA1} upload-sourcemaps --no-rewrite build-production/static/js | ||
| npm run sentry-cli -- --auth-token ${SENTRY_AUTH_TOKEN} releases --org audius --project audius-client files ${CIRCLE_SHA1} upload-sourcemaps --no-rewrite build-production/static/js |
There was a problem hiding this comment.
fyi I think you can also just do npx --no-install sentry-cli and we don't need the script in package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upload of sourcemaps broken on CI currently
https://app.circleci.com/pipelines/github/AudiusProject/audius-protocol/68085/workflows/8afcb8c3-463e-4963-ab72-e123239a781c/jobs/1000782
pnpmwould be nice here, but this works using npm's script module resolution. Remove redundant install in mobile.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
For web, was able to test via rerunning job with CI
For mobile, was only able to test locally that the script does find the right binary. Will test again on CI