Mitigate levitation issue #1152
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, all robots levitated a bunch and it looked really ugly, by lowering the suspension factor, some robots (like Dozer) will still levitate but not appear to do so. Other robots, however, will still have a minimum amount of levitation due to wheel suspension. I speculate that it has something to do with the physics of real vs toon robots, as that seemed to be the distinguishing factor, perhaps the dimensions or hit-boxes on the real robots are ill defined, or the wheel types work differently, I'm not really sure. The only way to fix it for them is to set the suspension constants to
0
, which causes collision-like issues with the ground (for some reason). To fix the collision issue, I tried disabling friction and printing for collisions, however, no collisions were being triggered when the robots tried and failed to be moved forward while touching the ground. I left this mini-investigation very confused.I'm going to come back to this ticket another time and take another crack at it, since I'm sure I could do better with a bit of inspiration and some more time to test
Objectives
Testing Done
JIRA Issue
Note
This PR doesn't exactly close this ticket, it's just a mitigation of the issue.