feat: add center of mass indicators and analysis tool panel #1153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rutmanz
added
rendering
BrandonPacewic
requested review from
ariesninjadev
and removed request for
Dhruv-0-Arora
ariesninjadev
requested changes
Jun 20, 2025
|
I'm inclined to agree that it would make sense as a setting, but the ticket specifies that it should be the start of a separate analysis mode/panel. cc @BrandonPacewic |
There was a problem hiding this comment.
It's preferable that one is able to continue viewing the CoM's of robots even after the analysis panel is closed. Further, it should be stored alongside other data in browser cache to preserve the setting. lmk if you disagree
Fix unit test **
I'm inclined to agree that it would make sense as a setting, but the ticket specifies that it should be the start of a separate analysis mode/panel. cc @BrandonPacewic
I think I agree with these suggestions. I'll take over this PR since @rutmanz is out for the week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an analysis panel (per the Jira ticket) and a center of mass indicator for robot bodies that can be enabled. Currently the center of mass sphere floats in front of the rest of the scene so it can be seen even when inside a mesh (like Dozer).
Testing Done
AARD-1817