Skip to content

Feature/89 fuzzy calendar#92

Open
SimpleSquirrelz wants to merge 34 commits intomainfrom
feature/89-fuzzy-calendar
Open

Feature/89 fuzzy calendar#92
SimpleSquirrelz wants to merge 34 commits intomainfrom
feature/89-fuzzy-calendar

Conversation

@SimpleSquirrelz
Copy link
Copy Markdown
Collaborator

No description provided.

@SimpleSquirrelz SimpleSquirrelz self-assigned this Jun 5, 2023
Comment thread src/components/calendars/WeekdayFilterCheckbox.tsx Outdated
Comment thread src/components/calendars/WeekdayFilterCheckbox.tsx Outdated
Comment thread src/components/calendars/TimePeriodGridItemsWithAdd.tsx Outdated
Comment thread src/components/calendars/TimePeriodGridItem.tsx Outdated
Comment thread src/components/simulationParameters/useFormState.ts Outdated
Comment thread src/components/calendars/ModelTypeSelect.tsx Outdated
Comment thread src/components/ResourceCalendars.tsx Outdated
Comment thread src/components/ResourceCalendars.tsx Outdated
Comment thread src/components/ResourceCalendars.tsx Outdated
Comment thread src/components/ResourceCalendars.tsx Outdated
Copy link
Copy Markdown
Collaborator

@ira-halenok ira-halenok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user should have an opportunity to setup / change the granule size not only when switching from crisp to fuzzy calendar. So I assume we need to add one more additional component to support this. For example, the following use case should work: user uploads .json file with granule size, they see the granule size value and can edit it.

Comment thread src/components/calendars/CalendarFuzzyGranuleDialog.tsx Outdated
Comment thread src/helpers/timeConversions.ts Outdated
Comment thread src/components/simulationParameters/useFormState.ts Outdated
Comment thread src/components/calendars/TimePeriodList.tsx Outdated
Comment thread src/components/calendars/WeekdayFilterCheckbox.tsx Outdated
Comment thread src/components/calendars/ConfirmationDialog.tsx Outdated
@ira-halenok
Copy link
Copy Markdown
Collaborator

Edit of granule_size does not work for me. UI component behaves not the way I expect.
It always shows 1 second despite the fact that I put number different than 1 (e.g., 60) and the system allowed me to save it.

Comment thread src/components/simulationParameters/useFormState.ts
@ira-halenok ira-halenok linked an issue Jun 29, 2023 that may be closed by this pull request
@SimpleSquirrelz SimpleSquirrelz marked this pull request as ready for review July 5, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fuzzy Calendars

2 participants