Forms: add time field #44272

simison · 2025-07-10T15:46:49Z

Adds as a beta block, so this is safe to merge as it won't show up to customers yet.

Uses browser native time input for starters. In a follow-up we might either add another style variation, explore styling the time field better by default, or override it with more custom picker like we do for date field.

Proposed changes:

Adds time field as a beta block

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

// Enable WP.com beta blocks
// https://github.com/Automattic/jetpack/blob/c903a93a1db5f44ff809bd25e9392b7dca45e079/projects/plugins/jetpack/extensions/README.md#beta-extensions
define('JETPACK_BLOCKS_VARIATION', 'beta'); // beta | experimental

Then add "time" field to your form.

github-actions · 2025-07-10T15:47:40Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the add/forms-time-field branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack add/forms-time-field

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

simison · 2025-07-10T15:47:54Z

projects/packages/forms/src/blocks/shared/settings/transforms.js

-	'jetpack/field-number',
-	'jetpack/field-date',
+	'jetpack/field-time',
+	'jetpack/field-url',


Alphabetic order

github-actions · 2025-07-10T15:48:04Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly:
- Scheduled release: August 5, 2025
- Code freeze: August 4, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

simison · 2025-07-10T15:48:07Z

projects/packages/forms/src/blocks/label/index.js

@@ -21,12 +21,13 @@ const settings = {
 		'jetpack/field-multiple-choice',
 		'jetpack/field-name',
 		'jetpack/field-number',
+		'jetpack/field-rating',


Alphabetic order

jp-launch-control · 2025-07-10T15:55:48Z

Code Coverage Summary

Coverage changed in 5 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/contact-form/class-contact-form-field.php	602/1037 (58.05%)	-0.52%	10 💔
projects/packages/forms/src/blocks/contact-form/class-contact-form-block.php	282/398 (70.85%)	-1.27%	7 💔
projects/packages/forms/src/blocks/input/edit.js	0/29 (0.00%)	0.00%	3 ❤️‍🩹
projects/packages/forms/src/contact-form/class-contact-form-plugin.php	424/1182 (35.87%)	-0.06%	2 ❤️‍🩹
projects/packages/forms/src/contact-form/class-contact-form.php	595/1068 (55.71%)	-0.06%	2 ❤️‍🩹

3 files are newly checked for coverage.

File	Coverage
projects/packages/forms/src/blocks/field-time/edit.js	0/2 (0.00%) 💔
projects/packages/forms/src/blocks/field-time/index.js	0/2 (0.00%) 💔
projects/packages/forms/src/blocks/field-time/save.js	0/2 (0.00%) 💔

Full summary · PHP report · JS report

_{Coverage check overridden by

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.
.}

simison · 2025-07-10T17:04:42Z

projects/packages/forms/src/contact-form/class-contact-form-field.php

@@ -689,7 +696,7 @@ public function render_input_field( $type, $id, $value, $class, $placeholder, $r
 			}
 		}

-		// this is a hack for Firefox to prevent users from falsly entering a something other then a number into a number field.
+		// this is a hack for Firefox to prevent users from falsely entering a something other than a number into a number field.


Unrelated typo fix

simison · 2025-07-10T17:04:47Z

projects/packages/forms/src/contact-form/class-contact-form-field.php

@@ -1447,7 +1454,7 @@ public function render_select_field( $id, $label, $value, $class, $required, $re
 	}

 	/**
-	 * Return the HTML for the email field.
+	 * Return the HTML for the date field.


Unrelated typo fix

ilonagl

Yay! I am glad we have this functionality.

It looks a bit odd to have it as a wide-input, but it's not a blocker for release.

Q: do we plan to offer any settings with this?

ilonagl · 2025-07-14T12:45:04Z

Some things we could improve (video walkthrough below (I'm using Arc browser)):

Currently, users might assume that clicking on the left-hand placeholders will open a time dropdown (in both the editor and front-end). While I understand these fields are for time input, this isn’t immediately clear. The dropdown only appears when clicking the clock icon, which could be mistaken for a decorative element. Can we make this interaction more intuitive?
On the front-end, the input fields appear very small—this might be a browser-specific issue, but it's worth checking.
Should we consider displaying timezone information? Time input can be confusing without clear timezone context, and this could lead to inconsistencies.

Time_picker_PR.mp4

dhasilva · 2025-07-14T19:34:16Z

I think it is best not to use the time input type, as its UI depends heavily on the browser. On Firefox it seems to not be possible to remove AM/PM:

I was looking for a solution to this and found this implementation by Mantine where they use two or more separate text inputs, giving them a control on the input that is not possible with the time input.

simison · 2025-07-15T08:36:09Z

It looks a bit odd to have it as a wide-input, but it's not a blocker for release.

Yep, agreed — we'll likely have a similar problem with other fields like number and some future address fields like zip code where we need to rethink how setting width works on fields.

Agreed on UX notes; I noted the same things in the issue earlier as well FORMS-18. I think what we'll do is that try preserve the native input as "style variation" as something site owners can choose to use, but that the default UX is more opinionated.

Since this is behind feature flag, I'll merge regardless, and then we can iterate.

simison added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress [Package] Forms labels Jul 10, 2025

simison commented Jul 10, 2025

View reviewed changes

github-actions bot added [Block] AI Assistant [Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Docs labels Jul 10, 2025

simison commented Jul 10, 2025

View reviewed changes

simison marked this pull request as ready for review July 10, 2025 15:52

simison requested review from ilonagl and a team July 10, 2025 16:13

simison added [Status] Needs Review This PR is ready for review. I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. and removed [Status] In Progress labels Jul 10, 2025

simison commented Jul 10, 2025

View reviewed changes

simison force-pushed the add/forms-time-field branch from d1e535e to b62ff5a Compare July 11, 2025 20:11

ilonagl previously approved these changes Jul 14, 2025

View reviewed changes

simison dismissed ilonagl’s stale review via 377f23b July 15, 2025 10:26

simison force-pushed the add/forms-time-field branch from 377f23b to e7a6ebf Compare July 15, 2025 10:27

simison added 2 commits July 17, 2025 17:42

Forms: add time field

737162e

Support time in input field

c542f9e

Update icon

84f2342

simison force-pushed the add/forms-time-field branch from e7a6ebf to 84f2342 Compare July 17, 2025 14:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Forms: add time field #44272

Forms: add time field #44272

Uh oh!

simison commented Jul 10, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 10, 2025 •

edited

Loading

Uh oh!

simison Jul 10, 2025

Uh oh!

github-actions bot commented Jul 10, 2025 •

edited

Loading

Uh oh!

simison Jul 10, 2025

Uh oh!

jp-launch-control bot commented Jul 10, 2025 •

edited

Loading

Uh oh!

simison Jul 10, 2025

Uh oh!

simison Jul 10, 2025

Uh oh!

ilonagl left a comment

Uh oh!

ilonagl commented Jul 14, 2025

Uh oh!

dhasilva commented Jul 14, 2025

Uh oh!

simison commented Jul 15, 2025

Uh oh!

Uh oh!

Forms: add time field #44272

Are you sure you want to change the base?

Forms: add time field #44272

Uh oh!

Conversation

simison commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simison Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simison Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

jp-launch-control bot commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

simison Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

simison Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

ilonagl left a comment

Choose a reason for hiding this comment

Uh oh!

ilonagl commented Jul 14, 2025

Uh oh!

dhasilva commented Jul 14, 2025

Uh oh!

simison commented Jul 15, 2025

Uh oh!

Uh oh!

simison commented Jul 10, 2025 •

edited

Loading

github-actions bot commented Jul 10, 2025 •

edited

Loading

github-actions bot commented Jul 10, 2025 •

edited

Loading

jp-launch-control bot commented Jul 10, 2025 •

edited

Loading