Boost: add filter to disable ISA UI

[kraftbj]

Fixes HOG-209

Proposed changes:

• Adds a filter that, by default, removes the ISA from the main Boost page.
• Removes reference to the feature in the upsell modal

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pc9hqz-3CD-p2

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

• On a new site, choose Free Boost.
• Ensures on the Boost settings page, there is not an upsell for the feature.
• Add paid Boost.
• Ensure there is not the ISA settings area.
• Add a filter:

  add_filter( 'jetpack_boost_image_size_analysis_display_ui', '__return_true' );

• See the settings on the Boost settings page.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

---

Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[jp-launch-control]

Code Coverage Summary

Coverage changed in 4 files.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/boost/app/modules/image-size-analysis/data-sync/class-data-sync-schema.php	0/117 (0.00%)	0.00%	5 💔
projects/plugins/boost/app/assets/src/js/features/image-guide/image-guide.tsx	0/7 (0.00%)	0.00%	1 ❤️‍🩹
projects/plugins/boost/app/assets/src/js/pages/index/index.tsx	0/16 (0.00%)	0.00%	1 ❤️‍🩹
projects/plugins/boost/app/modules/image-size-analysis/class-image-size-analysis.php	1/10 (10.00%)	10.00%	1 ❤️‍🩹

2 files are newly checked for coverage.

File	Coverage
projects/plugins/boost/app/assets/src/js/features/image-size-analysis/lib/stores/isa-ui-state.ts	0/2 (0.00%) 💔
projects/plugins/boost/app/modules/image-size-analysis/data-sync/class-image-size-analysis-ui-state.php	0/3 (0.00%) 💔

Full summary · PHP report · JS report

_{Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .}

[dilirity]

There's two small things and the rest are questions/notes.

After those are done, feel free to merge.

[dilirity]

I get the idea of the example. However, the Boost settings page is only accessible if you have manage_options cap.

It's a nitpick more than anything.

[kraftbj]

Ah, that's fair. I was just wanting to show an example of conditionally enabling the UI and didn't think about the if the example condition made sense.

applied suggestions