VideoPress: Prevent videopress blocks autoplaying inside iframe previews #44295

p-jackson · 2025-07-14T03:59:49Z

Part of DOTDASH-137

Proposed changes:

Prevent videopress blocks from autoplaying in Calypso iframe previews
It does this by changing the muted and autoplay attributes during render

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

The video shortcodes are already being prevented from autoplaying in an iframe preview. So by the same logic the videopress block should also

The ?iframe=true&preview=true logic isn't bullet proof. Theoretically a used could choose to use these query params too on their front end. But it is safe to change behaviour based on these flags because

We're already relying on these flags
The change is only minor, it does not for example, break video playback

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Testing Simple and VideoPress

On your test site, add a videopress video (ideally one with audio) to the front page. Set it to autoplay.
Sandbox your test site
Load your site's front end with ?iframe=true&preview=true query params
- The video does not auto play
Load your site's front end without the query params
- The video auto plays
https://wpcalypso.wordpress.com/v2 and find your site in grid view
- The video in the preview should not play
https://wordpress.com/home/{{ your test site }}
- Once My Home: Fix the site preview so it loads the expected admin-bar-blocking code wp-calypso#104713 is merged, the preview on My Home will not auto play.

Testing Atomic and VideoPress

Use The Jetpack beta plugin do the same tests on an atomic site

Testing Atomic and core/video

Disable the VideoPress feature from the JP dashboard /wp-admin/admin.php?page=jetpack#/dashboard
Upload a fresh video
- You can reupload the same video if you want but you have to delete the old copy from your media library first
- Any video file left over from when VideoPress was enabled will still have a videopress URL
In a new page add a core/video block, using your fresh video file
Load your site's front end with ?iframe=true&preview=true query params
- The video does not auto play
Load your site's front end without the query params
- The video auto plays

Other blocks to test

A core/video block that is pointing at a video press file
A core/cover block which is using a video background
A [wpvideo asdfksda] shortcode
An embed block, where a videopress url has been pasted

github-actions · 2025-07-14T04:00:44Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the DOTDASH-137-disable-videopress-in-preview branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack DOTDASH-137-disable-videopress-in-preview

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-07-14T04:00:53Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly:
- Scheduled release: August 5, 2025
- Code freeze: August 4, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

jp-launch-control · 2025-07-14T04:08:44Z

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/jetpack/_inc/lib/class.jetpack-iframe-embed.php	0/94 (0.00%)	0.00%	57 💔

Full summary · PHP report · JS report

_{If appropriate, add one of these labels to override the failing coverage check:

Covered by non-unit tests
Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code

Coverage tests to be added later
Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.}

fushar

Tested:

✅ VideoPress block
✅ core/video block

arthur791004 · 2025-07-14T10:32:26Z

projects/plugins/jetpack/_inc/lib/class.jetpack-iframe-embed.php

+		}
+
+		if ( $block['blockName'] === 'core/cover' && $block['attrs']['backgroundType'] === 'video' ) {
+			$block_content = self::change_element_src_query_param( $block_content, array( 'class_name' => 'wp-block-cover__video-background' ), 'autoPlay', '0' );


I think it autoplays with muted by default. It might be fine to leave it as is 🤔

p-jackson · 2025-07-14T23:49:35Z

I'm closing this in favour of the approach in 187730-ghe-Automattic/wpcom

p-jackson added 2 commits July 14, 2025 15:50

Prevent videopress blocks autoplaying inside iframe previews

9006073

changelog

8261700

p-jackson self-assigned this Jul 14, 2025

p-jackson requested a review from a team July 14, 2025 03:59

p-jackson added [Status] Needs Review This PR is ready for review. Bug labels Jul 14, 2025

github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jul 14, 2025

github-actions bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Jul 14, 2025

p-jackson added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. and removed Bug labels Jul 14, 2025

p-jackson changed the title ~~WIP change to disable videopress blocks inside iframe previews~~ VideoPress: Prevent videopress blocks autoplaying inside iframe previews Jul 14, 2025

p-jackson added the [Feature] VideoPress A feature to help you upload and insert videos on your site. label Jul 14, 2025

Disable autoplay for core/video blocks in iframes

9cbeadb

p-jackson force-pushed the DOTDASH-137-disable-videopress-in-preview branch from 3ec4bfc to 9cbeadb Compare July 14, 2025 04:54

fushar previously approved these changes Jul 14, 2025

View reviewed changes

Disable autoplay on core/video blocks using videopress files

c653011

p-jackson dismissed fushar’s stale review via c653011 July 14, 2025 05:34

Process the html within video blocks to remove videopress embeds

0a43230

arthur791004 reviewed Jul 14, 2025

View reviewed changes

p-jackson closed this Jul 14, 2025

github-actions bot removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] Needs Review This PR is ready for review. labels Jul 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

VideoPress: Prevent videopress blocks autoplaying inside iframe previews #44295

VideoPress: Prevent videopress blocks autoplaying inside iframe previews #44295

Uh oh!

p-jackson commented Jul 14, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 14, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 14, 2025 •

edited

Loading

Uh oh!

jp-launch-control bot commented Jul 14, 2025 •

edited

Loading

Uh oh!

fushar left a comment

Uh oh!

arthur791004 Jul 14, 2025

Uh oh!

p-jackson commented Jul 14, 2025

Uh oh!

Uh oh!

VideoPress: Prevent videopress blocks autoplaying inside iframe previews #44295

VideoPress: Prevent videopress blocks autoplaying inside iframe previews #44295

Uh oh!

Conversation

p-jackson commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

fushar left a comment

Choose a reason for hiding this comment

Uh oh!

arthur791004 Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

p-jackson commented Jul 14, 2025

Uh oh!

Uh oh!

p-jackson commented Jul 14, 2025 •

edited

Loading

github-actions bot commented Jul 14, 2025 •

edited

Loading

github-actions bot commented Jul 14, 2025 •

edited

Loading

jp-launch-control bot commented Jul 14, 2025 •

edited

Loading