Untangling: Show "Jetpack -> Subscribers" menu on all sites

[mmtr]

Fixes DOTCOM-13884

Proposed changes:

• Move the /subscribers/:site path to the Jetpack > Subscribers menu for all sites (that menu was previously only visible with the classic interface).
• The existing Users > Subscribers menu (only visible with the default interface) will now point to /subscribers/jetpack-subscribers/:site so we can inform users with a callout that the menu has been moved (see DOTCOM-13883). This menu will be removed after a month, and it's only visible to existing users.

Site / Interface	Before	After
Simple / Default	Jetpack > Subscribers does not exist.	Jetpack > Subscribers is now visible.
Simple / Classic	Jetpack > Subscribers already exists.	No changes.
Atomic / Simple	Jetpack > Subscribers does not exist.	Jetpack > Subscribers is now visible.
Atomic / Classic	Jetpack > Subscribers already exists.	No changes.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

• Apply these changes to your WP.com site
• Make sure that "Jetpack > Subscribers" is visible on the default admin interface
• Make sure it points to /subscribers/:site
• Make sure that "Tools > Monetize" is only visible on the default admin interface and only for existing users.
• Make sure it points to /subscibers/jetpack-subscribers/:site (on a follow-up, this route will display a callout, see see DOTCOM-13883).

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the dotcom-13884-untangling-ia-show-jetpack-subscribers-menu branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack dotcom-13884-untangling-ia-show-jetpack-subscribers-menu

bin/jetpack-downloader test jetpack-mu-wpcom-plugin dotcom-13884-untangling-ia-show-jetpack-subscribers-menu

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[jp-launch-control]

Code Coverage Summary

Coverage changed in 2 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/masterbar/src/admin-menu/class-wpcom-admin-menu.php	43/151 (28.48%)	0.37%	-2 💚
projects/packages/masterbar/src/admin-menu/class-atomic-admin-menu.php	65/149 (43.62%)	0.86%	-3 💚

Full summary · PHP report · JS report

[jeherve]

One thing we haven't done until now, but maybe worth considering, is whether we should show those menu items on WoA sites when the Subscriptions module is inactive. The menus aren't that useful when the feature is off, so maybe they should not be displayed?

[dsas]

All works fine for me, though Jeremy asks a good question 🤔 .

[mmtr]

when the Subscriptions module is inactive

Can that module be deactivated? I don't find it in the Modules page:

The base branch was changed.

[mmtr]

when the Subscriptions module is inactive

Can that module be deactivated? I don't find it in the Modules page

Looks like the Subscription module is renamed to Newsletter.

If I disable it, I still can manage the subscribers through the /subscribers/:site path, so apparently it doesn't matter whether the module is on or off? Or maybe I'm missing something.

I'm merging for now anyway, since this PR doesn't introduce a change in the menu visibility – it just moves it to a different location. If we need to unregister/hide the menu under some other circumstances, we can do it as a follow-up.