Skip to content

Forms: remove dependency injection webpack plugin #44307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2025

Conversation

enejb
Copy link
Member

@enejb enejb commented Jul 14, 2025

This PR removed the inclusion of the DependencyInjection plugin since this is something that is already handled by the
jetpackWebpackConfig.StandardPlugins code.

Proposed changes:

  • Remove the DependencyInjection in favour of the jetpackWebpackConfig.StandardPlugins inclusion.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1752504347300399-slack-C052XEUUBL4

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  1. Make sure that the build still happends as expected.
  2. Note that the modules do not include the already existing code. Code size should not increase.

@enejb enejb requested review from lezama and Copilot July 14, 2025 18:55
@enejb enejb self-assigned this Jul 14, 2025
@enejb enejb added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Package] Forms labels Jul 14, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR streamlines how the DependencyExtractionWebpackPlugin is applied by leveraging the existing jetpackWebpackConfig.StandardPlugins mechanism, removing manual instantiation and the direct package dependency.

  • Remove manual import and instantiation of DependencyExtractionWebpackPlugin
  • Enable DependencyExtractionPlugin via StandardPlugins
  • Clean up package.json and add a changelog entry

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
projects/packages/forms/tools/webpack.config.modules.js Remove manual plugin import and instantiation; toggle plugin via StandardPlugins
projects/packages/forms/package.json Remove direct dependency on @wordpress/dependency-extraction-webpack-plugin
projects/packages/forms/changelog/fix-forms-dependency-injection Add changelog entry for this fix
Comments suppressed due to low confidence (2)

projects/packages/forms/tools/webpack.config.modules.js:108

  • Consider adding an automated test to verify that enabling DependencyExtractionPlugin via StandardPlugins correctly includes the DependencyExtractionWebpackPlugin in the final webpack configuration.
					DependencyExtractionPlugin: true,

projects/packages/forms/changelog/fix-forms-dependency-injection:4

  • [nitpick] The changelog entry could be clearer by specifying that it removes the manual DependencyExtractionWebpackPlugin instantiation, e.g. "Remove manual DependencyExtractionWebpackPlugin instantiation."
Forms: Remove the dependency-injection inclusion

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@enejb enejb changed the title Fix/forms dependency injection Forms remove dependency injection webpack plugin Jul 14, 2025
@enejb enejb changed the title Forms remove dependency injection webpack plugin Forms: remove dependency injection webpack plugin Jul 14, 2025
Copy link
Contributor

github-actions bot commented Jul 14, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the fix/forms-dependency-injection branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/forms-dependency-injection
bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/forms-dependency-injection

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build artifacts in a local build look unchanged

@enejb enejb merged commit 4bb7f88 into trunk Jul 15, 2025
109 of 111 checks passed
@enejb enejb deleted the fix/forms-dependency-injection branch July 15, 2025 15:24
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Contact Form [Package] Forms [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants