-
Notifications
You must be signed in to change notification settings - Fork 823
Forms: remove dependency injection webpack plugin #44307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR streamlines how the DependencyExtractionWebpackPlugin is applied by leveraging the existing jetpackWebpackConfig.StandardPlugins
mechanism, removing manual instantiation and the direct package dependency.
- Remove manual import and instantiation of
DependencyExtractionWebpackPlugin
- Enable
DependencyExtractionPlugin
viaStandardPlugins
- Clean up
package.json
and add a changelog entry
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
projects/packages/forms/tools/webpack.config.modules.js | Remove manual plugin import and instantiation; toggle plugin via StandardPlugins |
projects/packages/forms/package.json | Remove direct dependency on @wordpress/dependency-extraction-webpack-plugin |
projects/packages/forms/changelog/fix-forms-dependency-injection | Add changelog entry for this fix |
Comments suppressed due to low confidence (2)
projects/packages/forms/tools/webpack.config.modules.js:108
- Consider adding an automated test to verify that enabling DependencyExtractionPlugin via StandardPlugins correctly includes the DependencyExtractionWebpackPlugin in the final webpack configuration.
DependencyExtractionPlugin: true,
projects/packages/forms/changelog/fix-forms-dependency-injection:4
- [nitpick] The changelog entry could be clearer by specifying that it removes the manual DependencyExtractionWebpackPlugin instantiation, e.g. "Remove manual DependencyExtractionWebpackPlugin instantiation."
Forms: Remove the dependency-injection inclusion
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build artifacts in a local build look unchanged
This PR removed the inclusion of the DependencyInjection plugin since this is something that is already handled by the
jetpackWebpackConfig.StandardPlugins code.
Proposed changes:
DependencyInjection
in favour of thejetpackWebpackConfig.StandardPlugins
inclusion.Other information:
Jetpack product discussion
p1752504347300399-slack-C052XEUUBL4
Does this pull request change what data or activity we track or use?
No
Testing instructions: