-
Notifications
You must be signed in to change notification settings - Fork 826
Forms: release rating and slider fields for WP.com customers #44998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
|
40eb54e
to
ea0afd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look straightforward. In my local dev environment, I tested to confirm that the slider and rating blocks only show when the block variation is set to experimental.
I wasn't quite sure how to test this on WordPress.com. Usually proxy a test domain and load this branch in your sandbox to test. But as soon as you proxy and access WordPress.com, both beta and experimental version show. I did confirm these blocks still show in this branch. But I can't confirm they will now show for other users who are not proxied, which they should.
In any case, this seems safe to merge.
Great to move these one step closer to full release!
Proposed changes:
jetpack/projects/plugins/jetpack/extensions/README.md
Line 109 in 4ec0394
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
define('JETPACK_BLOCKS_VARIATION', 'beta');
configured, blocks should not be available on Jetpack