Forms: Add input styles to image select field #45009
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of FORMS-60
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
For the warning fix:
For the block inserter behavior:
For the frontend styles:
Note: Contrary to all other use cases of checkboxes and radio inputs, this one sits on top of an image, which can be difficult to see depending on the colors and the image. Also, the way used on other places to determine colors will not work on this case as each option can be styled separately, so I used filters to determine a combination of colors based on the text color as a proposal.