-
Couldn't load subscription status.
- Fork 837
jetpack-mu-wpcom: Add code block #45181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
|
Excellent progress! 🎉 How can I test it? What's left to do? I see that it's implemented as a standalone block. What is your latest opinion about having it as a new block vs enhancing the Code ( |
I'll prepare an easy way to test this soon on WordPress.com. There's also the Jetpack Beta Tester plugin for testing on WordPress.com WP Cloud sites.
I just got it building and working, so I need to review things myself and make sure it's finished and all working correctly 🙂 |
1941e55 to
382f884
Compare
4dc1a27 to
0d87de7
Compare
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
This comment was marked as off-topic.
This comment was marked as off-topic.
f89f121 to
20b3dca
Compare
Use explicit UTF-8 encoding and true double-encode argument.
346913a to
1d3259d
Compare
select and custom select use different options object and spread pass props through. prevent a "key" prop warning
Proposed changes:
The block is disabled by default. It requires a filter to be activated. This PR introduces the implementation but does not enable any new functionality.
The block currently looks like this:
The block name and some warnings will be changed before final release but are still important to keep during testing.
Other information:
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
See pgsdXZ-aB-p2.
It's important to confirm that:
Before release, the block will undergo a complete Call for Testing.
The block can be tested with these filters: