-
Notifications
You must be signed in to change notification settings - Fork 839
Code block: Enhance core instead of new block #45389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 2 files.
Full summary · PHP report · JS report Coverage check overridden by
I don't care about code coverage for this PR
|
48ef0e5 to
ac86d97
Compare
7a82f40 to
3edb1c0
Compare
This reverts commit 7f6f067.
174496b to
056efa2
Compare
|
The failing PHP tests are pre-existing and not caused by this PR. |
Proposed changes:
Update the
a8c/codeblock to enhance thecore/codeblock instead of providing an independent block.Known issues:
The global styles system doesn't appear to recognize the block. For some reason, it does not add styles as expected. A code block with in default twentytwentyfive has a font family, but this is never added to the inline styles when the block override is in place:
Custom block
fontFamilyis currently disabled. Due to this global styles issue and other complexities,fontFamilysupport is not available but should be added at some point.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
The block is not enabled and will have thorough testing before release.
Testing setup instructions are here. It's available on sites with the
gutenberg-edgeflag for testing. The most important thing to verify is that the feature is not enabled by default. That logic has not changed in this PR.