Skip to content

Publicize: Mitigate obscure PHP fatals when REST receives malformed data #45418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 14, 2025
Merged

Publicize: Mitigate obscure PHP fatals when REST receives malformed data #45418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
396221a
Mitigate fatals
tbradsha Oct 8, 2025
52e0dfb
Add changelog
tbradsha Oct 8, 2025
081bcdf
Return WP_Error instead of empty array
tbradsha Oct 13, 2025
a6ba823
Simplify wording
tbradsha Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/publicize/changelog/fix-publicize-obscure_rest_fatals
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Sharing: Prevent PHP fatals when passed malformed data.
7 changes: 7 additions & 0 deletions projects/packages/publicize/src/class-rest-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,13 @@ public function register_rest_routes() {
return is_array( $param );
},
'sanitize_callback' => function ( $param ) {
if ( ! is_array( $param ) ) {
return new WP_Error(
'rest_invalid_param',
esc_html__( 'The skipped_connections argument must be an array of connection IDs.', 'jetpack-publicize-pkg' ),
array( 'status' => 400 )
);
}
return array_map( 'absint', $param );
},
),
Expand Down
7 changes: 7 additions & 0 deletions projects/packages/publicize/src/rest-api/class-share-post-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,13 @@ public function register_routes() {
return is_array( $param );
},
'sanitize_callback' => function ( $param ) {
if ( ! is_array( $param ) ) {
return new WP_Error(
'rest_invalid_param',
esc_html__( 'The skipped_connections argument must be an array of connection IDs.', 'jetpack-publicize-pkg' ),
array( 'status' => 400 )
);
}
return array_map( 'absint', $param );
},
),
Expand Down
Loading