Skip to content

Conversation

@lezama
Copy link
Contributor

@lezama lezama commented Oct 10, 2025

Proposed changes:

  • Add both path formats (with and without leading /) to preload data for compatibility with different apiFetch call patterns
  • Add _locale=user variant of filters endpoint to cache both request types

What this PR does:

  • Adds compatibility for API requests made with or without a leading / in the path (e.g., both wp/v2/feedback/filters and /wp/v2/feedback/filters)
  • Includes the _locale=user variant of the filters endpoint to ensure requests with locale parameters are also cached

Note: This PR improves preload coverage but does not fully fix the middleware registration issue. A follow-up PR will be needed to change the script handle from self::SCRIPT_HANDLE to 'wp-api-fetch'
and position from 'before' to 'after' (these changes were reverted by the linter).

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A - Performance optimization

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Open browser DevTools Network tab and filter for feedback requests
  • Navigate to Jetpack → Forms → Inbox
  • Verify no requests are made
  • Check that the inbox loads correctly with form responses, filters, and counts displayed

Ref: #45339

@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the forms/fix-preload-middleware branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack forms/fix-preload-middleware

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 10, 2025
@lezama lezama requested a review from a team October 10, 2025 03:07
@jp-launch-control
Copy link

jp-launch-control bot commented Oct 10, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/dashboard/class-dashboard.php 23/113 (20.35%) -0.56% 3 ❤️‍🩹

Full summary · PHP report · JS report

@simison
Copy link
Member

simison commented Oct 10, 2025

Should we go through usage and make sure we're calling the filters API consistently with or without a trailing /?

@lezama lezama force-pushed the forms/fix-preload-middleware branch from 8285d83 to 7c9c5e3 Compare October 10, 2025 13:16
@lezama lezama merged commit b13dc1b into trunk Oct 10, 2025
67 checks passed
@lezama lezama deleted the forms/fix-preload-middleware branch October 10, 2025 13:58
@github-actions github-actions bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants