Skip to content

My Jetpack page: fix visual compatibility issue with Hello Dolly plugin. #45474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 14, 2025
Merged

My Jetpack page: fix visual compatibility issue with Hello Dolly plugin. #45474

merged 5 commits into from
Oct 14, 2025

Conversation

simison
Copy link
Member

@simison simison commented Oct 10, 2025 •
edited
Loading

Fixes JETPACK-898

Proposed changes:

Before

Screenshot 2025-10-11 at 00 53 15

After

Desktop
Screenshot 2025-10-11 at 00 53 09

Mobile

image

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Enable Hello Dolly plugin
  • Go to My Jetpack page

@simison simison requested review from a team and nerrad October 10, 2025 22:00
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/jetpack-hello-dolly branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/jetpack-hello-dolly

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Package] My Jetpack [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. labels Oct 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: November 4, 2025
    • Code freeze: November 3, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Backup plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Search plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Social plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Starter Plugin plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Protect plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Videopress plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 10, 2025
@jp-launch-control JP Launch Control
Copy link

jp-launch-control bot commented Oct 10, 2025 •
edited
Loading

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

nerrad
nerrad reviewed Oct 12, 2025
View reviewed changes
Copy link
Contributor

@nerrad nerrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS fix here seems okay since it keeps Hello Dolly lyrics showing up for those who want that. A few things that surfaced in testing:

I verified RTL works okay:

Image

The Forms page doesn't show the Hello Dolly text:

Image

Settings page has more styling:

Image

@simison
Copy link
Member Author

simison commented Oct 12, 2025

I also tested Social, Stats and few other pages and didn't find issues:

Screenshot 2025-10-11 at 00 54 46 Screenshot 2025-10-11 at 00 55 50

An alternative approach would be to adjust My Jetpack header styles so that Hello Dolly text would work without special targeting, but I don't feel strongly either way.

grzegorz-cp
grzegorz-cp reviewed Oct 13, 2025
View reviewed changes
Copy link
Contributor

@grzegorz-cp grzegorz-cp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from the Forms page, like mentioned above. We could also hide it from the connection page.

projects/packages/my-jetpack/_inc/style.module.scss
padding-right: 10px;
}
}

Copy link
Contributor

@grzegorz-cp grzegorz-cp Oct 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.jetpack-admin-full-screen p#dolly {
display: none;
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I don't like the idea of hiding it; when enabled the idea is that it shows up everywhere. It's not intentionally hidden on Forms page either (to my knowledge), and on some older Jetpack pages we have even more elaborate CSS to make it behave nice with Jetpack headers and JITMs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it breaks the design of the connection page, that don't even have the left sidebar. It also feels taken out of context when it's on that page.

Copy link
Member Author

@simison simison Oct 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, I think your reasoning makes sense if the page you refer to isn't something users return to. 👍

manzoorwanijk
manzoorwanijk reviewed Oct 13, 2025
View reviewed changes
@simison
Copy link
Member Author

simison commented Oct 13, 2025

@grzegorz-cp @manzoorwanijk can your team handle adding/testing/deploying the changes on My Jetpack/connection pages from here? One thing to consider could be applying styles from the settings page to My Jetpack as well, but it's also fine without.

image

@manzoorwanijk
Copy link
Member

@grzegorz-cp @manzoorwanijk can your team handle adding/testing/deploying the changes on My Jetpack/connection pages from here?

I have updated the CSS to hide it on connection page

One thing to consider could be applying styles from the settings page to My Jetpack as well, but it's also fine without.

I think it's fine as is because the settings page seems to customize it, which I think is not necessary.

manzoorwanijk
manzoorwanijk approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@manzoorwanijk manzoorwanijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well now.

grzegorz-cp
grzegorz-cp approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@grzegorz-cp grzegorz-cp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes.

@simison simison added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Oct 14, 2025
@simison simison added the [Type] Bug When a feature is broken and / or not performing as intended label Oct 14, 2025
@manzoorwanijk manzoorwanijk merged commit 0028158 into trunk Oct 14, 2025
87 of 90 checks passed
@manzoorwanijk manzoorwanijk deleted the fix/jetpack-hello-dolly branch October 14, 2025 08:46
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nerrad nerrad nerrad left review comments

@manzoorwanijk manzoorwanijk manzoorwanijk approved these changes

@grzegorz-cp grzegorz-cp grzegorz-cp approved these changes

Assignees

No one assigned

Labels

[Package] My Jetpack [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simison @manzoorwanijk @nerrad @grzegorz-cp