Skip to content

fix(ads): move shared sticky ads styles to newspack-ads plugin#233

Draft
laurelfulford wants to merge 4 commits into
mainfrom
fix/move-sticky-ad-styles
Draft

fix(ads): move shared sticky ads styles to newspack-ads plugin#233
laurelfulford wants to merge 4 commits into
mainfrom
fix/move-sticky-ad-styles

Conversation

@laurelfulford

@laurelfulford laurelfulford commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR moves some sticky footer ad styles from the classic theme to the Newspack Ads plugin, so they can be shared with the block theme.

I also moved any non-theme-specific or non-theme-dependant AMP ad styles.

Closes NPPD-1643

How to test the changes in this Pull Request:

  1. Do a visual comparison of the classic theme on main and this branch, and confirm things look the same.
  2. Confirm that no CSS was lost in this change (I tidied up the Newspack Ads CSS file a bit to reduce selector duplication).

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

@laurelfulford laurelfulford changed the title fix: move shared sticky ads styles to newspack-ads plugin fix(ads): move shared sticky ads styles to newspack-ads plugin Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant